-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(icons): added small-airplane icon
#3833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 ChatGPT Tags suggestions ✨
I've asked ChatGPT for some suggestions for tags.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Hey @roygommer, Can you please provide use cases that are unique to this one as opposed to also applicable to our regular airplane icon? Additionally, neither the icon nor its name is guideline compliant, see more at: https://lucide.dev/guide/design/icon-design-guide |
Hi @karsa-mistmere, Do have suggestions to make it compliant? |
Added or changed iconsIcons as codeWorks for: const SmallAirplaneIcon = createLucideIcon('SmallAirplane', [
["path",{"d":"M 10 7 L 14 7"}],
["path",{"d":"M 12 18 L 12 19.5"}],
["path",{"d":"M 12 5 L 12 5"}],
["path",{"d":"M12 5v13"}],
["path",{"d":"M2 9h20"}],
["path",{"d":"M8 9l4 4l4-4"}],
["path",{"d":"M9 18h6"}]
]) |
Honestly, this feels like a pretty niche use case. Do you think we could pick one specific type of small aircraft, which has further use cases other than representating small aircraft in general and use that?
The name should be The design is not so simple, but the core issue is that there should be a 2px gap between all elements, so creating the illusion of fills via paths is a big no no, since that will result in inconsistent look between various stroke widths, see the generated stroke width preview above. |
|
Ma-a-a-a-a-ybe something like this? The back of the fuselage gets a bit narrow, which goes against Lucide design guidelines, but the current But for cases this niche, it might be that you host this icon yourself rather than rely on it being part of Lucide. |
What is the purpose of this pull request?
Description
Added new
small-airplaneicon.Icon use case
To use in the selection menu of a website containing weather information for different kind of aircraft.
To use do decorate a webpage containing all sorts of aircraft.
To demonstrate a small airplane.
Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json.Design
Before Submitting